-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1190: Added runtime support for doing golden comparision for flatbuffers in ttrt #1218
Conversation
dadf65f
to
315788b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Taps, things are looking great! Commented inline for a few API improvements.
9a1457a
to
e9cf188
Compare
e9cf188
to
015d3be
Compare
018095b
to
5a40629
Compare
d958bfb
to
21a7384
Compare
fixed all the issues. @jnie-TT @nsmithtt Let me know if there's something missing. @nsmithtt I tried to pybind the tt::target::GoldenTensor but it ended up complaining a ton about mismatch between data type (ie the autogenerated from flatbuffer compiler and what I was trying to pybind). So I have this workaround
I'm not 100% with this workaround :) however |
4a90156
to
ea1d74f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Taps, it's looking really close! Some more comments inline
ea1d74f
to
08476bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really great! Thank you for being receptive to my pedantry.
911ddd6
to
4d55210
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor things left, otherwise I think it's good to go!
4d55210
to
b5cdf01
Compare
Many pcc issues with several ops resolved :D. Remaining ones
|
The goal of this PR is to introduce golden support in runtime. The design was taken into account that other runtimes can plug into MLIR runtime (ttrt is just one possible frontend for mlir runtime). The frontend building off MLIR runtime can register a "callback" function through python, which will return ProgramContext* and Operation* - to be run after every op is executed. The frontend can then call supporting APIs to return currently running data.
Some ops have bad pcc: following up bad pcc ops in separate issues. Parent issue: #1219