Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#105: Added noc and l1 alignment variables into flatbuffer #159

Merged
merged 1 commit into from
Jul 18, 2024
Merged

#105: Added noc and l1 alignment variables into flatbuffer #159

merged 1 commit into from
Jul 18, 2024

Conversation

tapspatel
Copy link
Collaborator

No description provided.

@tapspatel tapspatel self-assigned this Jul 16, 2024
@tapspatel tapspatel requested a review from nsmithtt as a code owner July 16, 2024 20:10
@tapspatel tapspatel linked an issue Jul 16, 2024 that may be closed by this pull request
Add Address Alignment Constraints to ChipDesc #105
Closed
@tapspatel
Copy link
Collaborator Author

Tested with:

cmake --build build -- check-ttmlir

./build/bin/ttmlir-opt --ttir-to-ttnn-backend-pipeline --ttnn-serialize-to-binary="output=out.ttnn" test/ttmlir/Dialect/TTNN/simple_multiply.mlir
ttrt read out.ttnn &> debug.log

ttrt query --save-system-desc n150.ttsys
ttrt read n150.ttsys

@tapspatel tapspatel mentioned this pull request Jul 16, 2024
Closed
nsmithtt
nsmithtt requested changes Jul 16, 2024
View reviewed changes
runtime/lib/ttnn/runtime.cpp Outdated Show resolved Hide resolved
third_party/CMakeLists.txt Outdated Show resolved Hide resolved
@tapspatel tapspatel requested a review from nsmithtt July 16, 2024 20:23
nsmithtt
nsmithtt approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@nsmithtt nsmithtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@tapspatel tapspatel merged commit 949df8e into main Jul 18, 2024
3 checks passed
@tapspatel tapspatel deleted the tpatel/issue-105 branch August 30, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsmithtt nsmithtt nsmithtt approved these changes

Assignees

@tapspatel tapspatel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Address Alignment Constraints to ChipDesc
2 participants
@tapspatel @nsmithtt