Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GridSetPass] Fix handling of FuncOp with multiple results. #187

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[GridSetPass] Fix handling of FuncOp with multiple results. #187

merged 1 commit into from
Jul 18, 2024

Conversation

nobradovictt
Copy link
Contributor

  • Fix scenario where more than one result is returned from func::FuncOp.
  • Add test with multiple returns and with some location data to start POC work on leveraging it.

@nobradovictt nobradovictt self-assigned this Jul 17, 2024
@nobradovictt nobradovictt requested a review from nsmithtt as a code owner July 17, 2024 14:36
nsmithtt
nsmithtt approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@nsmithtt nsmithtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! And let me know how the location info pans out

@nobradovictt nobradovictt force-pushed the nobradovic/grid_set_fix_mul_return branch from 9324193 to f39abe2 Compare July 18, 2024 09:52
@nobradovictt nobradovictt merged commit 32f4863 into main Jul 18, 2024
3 checks passed
@nobradovictt nobradovictt deleted the nobradovic/grid_set_fix_mul_return branch July 18, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsmithtt nsmithtt nsmithtt approved these changes

@sdjordjevicTT sdjordjevicTT sdjordjevicTT approved these changes

@rpavlovicTT rpavlovicTT Awaiting requested review from rpavlovicTT

@mrakitaTT mrakitaTT Awaiting requested review from mrakitaTT mrakitaTT is a code owner

Assignees

@nobradovictt nobradovictt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nobradovictt @nsmithtt @sdjordjevicTT