remove reduce ops workaround for keepDim attribute #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmanzoorTT
force-pushed
the
mmanzoor/reduce-op-remove-wa
branch
4 times, most recently
from
c2def74 to
2236c94
Compare
mmanzoorTT
requested review from
sdjordjevicTT,
svuckovicTT,
mtopalovicTT,
jserbedzijaTT and
azecevicTT
as code owners
include/ttmlir/Dialect/TTNN/Transforms/Workarounds/Decomposition/ReduceOpsRewritePattern.h
Outdated
Show resolved
Hide resolved
mmanzoorTT
force-pushed
the
mmanzoor/reduce-op-remove-wa
branch
2 times, most recently
from
2e24b3f to
ae3c8ae
Compare
mrakitaTT
reviewed
Jan 30, 2025
include/ttmlir/Dialect/TTNN/Transforms/Workarounds/Decomposition/ReduceOpsRewritePattern.h
Outdated
Show resolved
Hide resolved
|
@mmanzoorTT Thank you for making these changes! Just to make sure, you've verified that tests now pass in debug mode too? :) (because metal fix was unstable in debug mode) |
mmanzoorTT
force-pushed
the
mmanzoor/reduce-op-remove-wa
branch
from
ae3c8ae to
ced1b40
Compare
Yes. I tested metal fix in debug mode and all the tests worked :) |
mrakitaTT
requested changes
Jan 31, 2025
include/ttmlir/Dialect/TTNN/Transforms/Workarounds/Decomposition/ReduceOpsRewritePattern.h
Outdated
Show resolved
Hide resolved
mmanzoorTT
force-pushed
the
mmanzoor/reduce-op-remove-wa
branch
from
ced1b40 to
da50ff3
Compare
mrakitaTT
reviewed
Feb 5, 2025
include/ttmlir/Dialect/TTNN/Transforms/Workarounds/Decomposition/ReduceOpsRewritePattern.h
Outdated
Show resolved
Hide resolved
mmanzoorTT
force-pushed
the
mmanzoor/reduce-op-remove-wa
branch
from
da50ff3 to
3c46c36
Compare
mrakitaTT
approved these changes
Feb 6, 2025
include/ttmlir/Dialect/TTNN/Transforms/Workarounds/Decomposition/ReduceOpsRewritePattern.h
Outdated
Show resolved
Hide resolved
include/ttmlir/Dialect/TTNN/Transforms/Workarounds/Decomposition/ReduceOpsRewritePattern.h
Outdated
Show resolved
Hide resolved
* Enable workaround for partial and full tensor reduction if 'KeepDim' attribute is not supported. * Enable workaround for full tensor reduction if 'KeepDim' attribute is supported.
mmanzoorTT
force-pushed
the
mmanzoor/reduce-op-remove-wa
branch
from
3c46c36 to
1a92710
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workaround is still required in case of reducing entire tensor.
closes #1640