Refactor conv2d op and add conv2d config support #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserbedzijaTT
requested review from
jnie-TT,
kmabeeTT,
AleksKnezevic,
pilkicTT,
sdjordjevicTT,
svuckovicTT,
mtopalovicTT,
azecevicTT,
nsmithtt,
mrakitaTT and
tapspatel
as code owners
jserbedzijaTT
force-pushed
the
jserbedzija/add_conv2d_config
branch
3 times, most recently
from
a97aece to
147c7b9
Compare
odjuricicTT
reviewed
Jan 31, 2025
jserbedzijaTT
force-pushed
the
jserbedzija/add_conv2d_config
branch
3 times, most recently
from
c4d787f to
c64caa0
Compare
jserbedzijaTT
force-pushed
the
jserbedzija/add_conv2d_config
branch
3 times, most recently
from
72c7bc9 to
3eef128
Compare
LPanosTT
approved these changes
Feb 4, 2025
jserbedzijaTT
force-pushed
the
jserbedzija/add_conv2d_config
branch
4 times, most recently
from
e92eea5 to
c52e15d
Compare
sdjordjevicTT
approved these changes
Feb 5, 2025
jserbedzijaTT
force-pushed
the
jserbedzija/add_conv2d_config
branch
from
c52e15d to
85e6bf6
Compare
odjuricicTT
approved these changes
Feb 6, 2025
jserbedzijaTT
force-pushed
the
jserbedzija/add_conv2d_config
branch
from
85e6bf6 to
f33a304
Compare
jnie-TT
reviewed
Feb 6, 2025
| config.weights_dtype = utils::getDataType(op->weight()); | ||
|
|
||
| std::array<uint32_t, 2> kernelSize, stride, padding, dilation; | ||
| std::copy_n(op->kernel_size()->begin(), 2, kernelSize.begin()); |
There was a problem hiding this comment.
Maybe add some asserts here like we did for convTranspose2D
jnie-TT
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the conv2d op to better align with the TTNN interface and improved verification in both the TTIR and TTNN dialects
Added the conv2d_config for the conv2d op in the TTNN dialect. Closes [TTNN Dialect] Conv2d op missing some optional parameters #1681