Remove dep. on runtime workaround in binary.cpp
#2104
Conversation
ctodTT
requested review from
jnie-TT,
kmabeeTT,
AleksKnezevic and
pilkicTT
as code owners
|
@jnie-TT in general we want to only have flatbuffer related code linked into the binary.cpp target for TTRT which is intended only for flatbuffer reflection and can be used offline (on macOS). All that said, the workarounds struct is probably a gray area since it's not strictly a standalone thing. We initially tried to link the workarounds lib into the binary.cpp lib via setup.py, but it didn't immediately work so we opted for this simpler solution. |
| @@ -39,10 +38,6 @@ static std::string asJson(void const *fbb, uint8_t const *binarySchema, | |||
|
|
|||
| static std::vector<uint32_t> | |||
| calculateStride(std::vector<uint32_t> const &shape) { | |||
| LOG_ASSERT( | |||
| workaround::Env::get().defaultStrideComputation, | |||
There was a problem hiding this comment.
Since we're not using this anymore, maybe we should remove the workaround entirely from workaround env, ttrt etc., and move the TODO comment here
There was a problem hiding this comment.
done! let me know if I missed anything, but otherwise will probably merge once CI passes
ctodTT
force-pushed
the
ctod/fix/remove-workaround-dep
branch
from
cb29695 to
852e16e
Compare
ctodTT
force-pushed
the
ctod/fix/remove-workaround-dep
branch
from
852e16e to
aeeb0a7
Compare
This change is made to avert an innocuous bug where `ttrt` can't find a symbol when it is built in debug mode.
ctodTT
force-pushed
the
ctod/fix/remove-workaround-dep
branch
from
aeeb0a7 to
26a66d2
Compare
This change is made to avert an innocuous bug where
ttrtcan't find a symbol when it is built in debug mode.Problem description
Sometimes the symbol
_ZN2tt7runtime10workaround3Env3getEbbbbbis missing from aDebugbuiltttrt.What's changed
The code that introduces a dependency on that symbol has been removed