Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default conv weights on host #2135

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Default conv weights on host #2135

merged 1 commit into from
Feb 6, 2025

Conversation

jnie-TT
Copy link
Contributor

@jnie-TT jnie-TT commented Feb 6, 2025

Defaults conv weights layout to host since they need to be prepared on host anyway. Patches uplift CI failures on tt-torch and tt-forge-fe.

FYI: @kmabeeTT @AleksKnezevic @pilkicTT

@mtopalovicTT
Copy link
Contributor

Side question. What was motivation for TTNNLayoutFuncInputOutputTypeRewriter pass? I might have missed your explanation somewhere. To my knowledge we don't have cases where inputs/outputs of func is on device

@jnie-TT
Copy link
Contributor Author

jnie-TT commented Feb 6, 2025

Side question. What was motivation for TTNNLayoutFuncInputOutputTypeRewriter pass? I might have missed your explanation somewhere. To my knowledge we don't have cases where inputs/outputs of func is on device

Hey @mtopalovicTT yeah we didn't previously but with a recent runtime stitching PR that went in all inputs/outputs now default on dram and are tiled, so that we can pre-push weights of models to device

@mtopalovicTT
Copy link
Contributor

Side question. What was motivation for TTNNLayoutFuncInputOutputTypeRewriter pass? I might have missed your explanation somewhere. To my knowledge we don't have cases where inputs/outputs of func is on device

Hey @mtopalovicTT yeah we didn't previously but with a recent runtime stitching PR that went in all inputs/outputs now default on dram and are tiled, so that we can pre-push weights of models to device

@jnie-TT Ahhh I somehow missed that part when I reviewed that change. Makes sense now.

@kmabeeTT
Copy link
Contributor

kmabeeTT commented Feb 6, 2025

Thanks Jackson. Since FEs are all busted right now on models let's merge when CI passes before 24 hours since this was already tested against forge and torch CI.

@jnie-TT jnie-TT merged commit 6578419 into main Feb 6, 2025
31 checks passed
@jnie-TT jnie-TT deleted the jnie/tt-torch-test branch February 6, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants