Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change TOSA->TTIR to use dialect conversion API #230

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Change TOSA->TTIR to use dialect conversion API #230

merged 1 commit into from
Jul 26, 2024

Conversation

rpavlovicTT
Copy link
Contributor

Fixes #178

Added conversion lib that implements conversion from TOSA to TTIR. Did not add new coverage of TOSA ops, it still supports only add, mul, sub, geq ops. Type conversion is still a no-op.

Removed old conversion.

Added MLIRTTConversions lib that links all conversion libs and is linked against TTMLIR.

@rpavlovicTT rpavlovicTT self-assigned this Jul 25, 2024
rpavlovicTT
rpavlovicTT commented Jul 25, 2024
View reviewed changes
lib/CMakeLists.txt Outdated Show resolved Hide resolved
@svuckovicTT
Copy link
Contributor

LGTM! Make sure you rebase, Ogi has added dialect conversion for ttir->ttnn.

@rpavlovicTT rpavlovicTT force-pushed the rpavlovic/tosa_to_ttir branch 2 times, most recently from cadf9b7 to d798333 Compare July 25, 2024 14:51
@rpavlovicTT
Change TOSA->TTIR to use dialect conversion API
dec3bd1 
Fixes #178

Added conversion lib that implements conversion from TOSA to TTIR.
Did not add new coverage of TOSA ops, it still supports only add, mul,
sub, geq ops. Type conversion is still a no-op.

Removed old conversion.

Added MLIRTTConversions lib that links all conversion libs and is linked
against TTMLIR.
@rpavlovicTT rpavlovicTT force-pushed the rpavlovic/tosa_to_ttir branch from d798333 to dec3bd1 Compare July 26, 2024 08:01
odjuricicTT
odjuricicTT reviewed Jul 26, 2024
View reviewed changes
lib/Conversion/TosaToTTIR/TosaToTTIR.cpp
}

auto outputType =
srcOp.getResult().getType().template cast<RankedTensorType>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be done using the type converter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment I doubt it. Reason is TOSA ops don't use DPS, therefore output tensor is not given among operands. So I don't see how TypeConverter would convert it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could actually explicity run the typeconverter on the result type, I did it in ttnn->emitc, but I'm not sure what would be considered a "better" approach.

(I realize this has already been committed, just wanted to share my thoughts...)

lib/Conversion/TosaToTTIR/TosaToTTIR.cpp Show resolved Hide resolved
@rpavlovicTT rpavlovicTT merged commit d817a8f into main Jul 26, 2024
5 of 6 checks passed
@rpavlovicTT rpavlovicTT deleted the rpavlovic/tosa_to_ttir branch July 26, 2024 12:00
vprajapati-tt added a commit that referenced this pull request Jul 29, 2024
@vprajapati-tt
Squashed commit of the following:
7317357 
commit 5ebfe37
Author: Sasa Vuckovic <134393361+svuckovicTT@users.noreply.github.com>
Date:   Mon Jul 29 16:42:29 2024 +0200

    Small refactor to ttnn-to-emitc pass (#229)

    * small refactor to ttnn-to-emitc pass

    * Remove unused constructor in DefaultOpConversionPattern

    * run pre-commit hooks that didn't get picked up

    * remove PassDetail.h

commit 60ad1a8
Author: Usman Aziz <uaziz@tenstorrent.com>
Date:   Mon Jul 29 10:29:46 2024 -0400

    Update flatbuffers dependency to allow bezel builds without python dependency. (#233)

commit 47a54b1
Author: Nikola Obradovic <132568163+nobradovictt@users.noreply.github.com>
Date:   Mon Jul 29 12:45:28 2024 +0200

    [Optimizer] Setting up rough shape of optimizer pass. Expanding analysis. (#236)

commit 29e618e
Author: Nick Smith <127986401+nsmithtt@users.noreply.github.com>
Date:   Sat Jul 27 15:24:27 2024 -0700

    embed sdk in ccache (#237)

commit 91e6b15
Author: Nick Smith <127986401+nsmithtt@users.noreply.github.com>
Date:   Fri Jul 26 19:51:25 2024 -0700

    Fix mac build; link against MLIR dylib (#239)

commit d817a8f
Author: Radenko Pavlovic <133032400+rpavlovicTT@users.noreply.github.com>
Date:   Fri Jul 26 14:00:45 2024 +0200

    Change TOSA->TTIR to use dialect conversion API (#230)

    Fixes #178

    Added conversion lib that implements conversion from TOSA to TTIR.
    Did not add new coverage of TOSA ops, it still supports only add, mul,
    sub, geq ops. Type conversion is still a no-op.

    Removed old conversion.

    Added MLIRTTConversions lib that links all conversion libs and is linked
    against TTMLIR.

commit 39ca8e2
Author: Nikola Obradovic <132568163+nobradovictt@users.noreply.github.com>
Date:   Fri Jul 26 09:15:16 2024 +0200

    [Misc] Rename TTIR op interface to TTIROp. (#227)

commit 01c19bd
Author: Ognjen Djuricic <160603639+odjuricicTT@users.noreply.github.com>
Date:   Thu Jul 25 09:54:25 2024 +0200

    Change ttir->ttnn to use dialect conversion api (#177) (#221)

commit 1fcda08
Author: Nick Smith <127986401+nsmithtt@users.noreply.github.com>
Date:   Wed Jul 24 12:12:42 2024 -0700

    Add `tt.device` spec #91 (#213)

commit a2f8e01
Author: Predrag Ilkic <148892209+pilkicTT@users.noreply.github.com>
Date:   Wed Jul 24 19:49:25 2024 +0200

    [docs] fix build on linux (#224)

    It looks like the `cp -r` command behaves differently on linux vs macOS.

    `cp -r dir/ new_dir/` will copy contents of the `dir/` into `new_dir/`
    on macOS, but on Linux, it will copy the directory, so you would end
    up with `new_dir/dir/`.

    Hence, changing the command to be:
    `cp -r dir/* new_dir/` which works the same on both platforms.

    Updating the docs for building docs as well.

commit 7345e48
Author: Milan Topalovic <163355844+mtopalovicTT@users.noreply.github.com>
Date:   Wed Jul 24 12:11:54 2024 +0200

    Adding translation from ttnn to flatbuffer (#216)

    We can now use ttmlir-translate tool to translate from TTNN IR to flatbuffer. Example:

    `./build/bin/ttmlir-opt --ttir-to-ttnn-backend-pipeline test/ttmlir/Dialect/TTNN/simple_matmul.mlir | ./build/bin/ttmlir-translate --ttnn-to-flatbuffer -o out.ttnn`

    To get flatbuffer from tt-forge we call std::vector<uint8_t> ttnnToFlatbuffer(Operation *op).

    resolves #120

commit 5cc95a4
Author: Stefan Djordjevic <157365107+sdjordjevicTT@users.noreply.github.com>
Date:   Wed Jul 24 10:25:56 2024 +0200

    Rewriting pipelines and transformation passes headers in LLVM style (#219)

commit a46f4f1
Author: Predrag Ilkic <148892209+pilkicTT@users.noreply.github.com>
Date:   Tue Jul 23 18:14:09 2024 +0200

    [tensor-layout] implements LayoutAttr::getStride() (#185)

    Initial implementation of stride calculation from the logical shape
    and the `LayoutAttr`. The strides of the tensors are stored in the
    Flatbuffer and are used by FE to allocate the tensors.

commit 6841e4d
Author: Nikola Obradovic <132568163+nobradovictt@users.noreply.github.com>
Date:   Tue Jul 23 09:50:31 2024 +0200

    [Optimizer] Per op grid overrides. (#206)

commit 2574010
Author: Radenko Pavlovic <133032400+rpavlovicTT@users.noreply.github.com>
Date:   Tue Jul 23 09:39:15 2024 +0200

    Eltwise interface and builders (#214)

    Fixes #110

commit f2c8b0b
Author: Jackson Nie <jnie@tenstorrent.com>
Date:   Mon Jul 22 16:02:14 2024 -0400

    Add runtime gtest and linker fix (#209)

    * Initial cmake changes for runtime gtest infra

    * Update instantiation of TTNN_LIBRARY

    * Fix linker error on fresh clone

commit ccbcfbf
Author: Nick Smith <127986401+nsmithtt@users.noreply.github.com>
Date:   Mon Jul 22 06:58:15 2024 -0700

    Debugging python (#211)

commit 25bb6ae
Author: Vladimir Milosevic <157983820+vmilosevic@users.noreply.github.com>
Date:   Mon Jul 22 10:21:20 2024 +0200

    Group workflows (#205)

    Organize workflows by grouping them in the parent workflow

    - adding top-level workflow 'on-pr-and-push-to-main' to group workflows
    - adding workflow dispatch to workflows to enable manual runs
    - added runtime on/off to cache key
    - update action versions
    - refactor build.yml matrix to dictionary

commit 704905a
Author: Muhammad Asif Manzoor <mmanzoor@tenstorrent.com>
Date:   Fri Jul 19 11:14:14 2024 -0400

    Add greater or equal op end to end (#200)

commit fc4f4ac
Author: Vladimir Milosevic <157983820+vmilosevic@users.noreply.github.com>
Date:   Fri Jul 19 09:52:54 2024 +0200

    Show and upload test report (#195)

    Display test summary and upload artifacts

commit 4fdde56
Author: Nick Smith <127986401+nsmithtt@users.noreply.github.com>
Date:   Thu Jul 18 12:36:53 2024 -0700

    Add Code of Conduct (#199)

commit 107fd54
Author: Jackson Nie <jnie@tenstorrent.com>
Date:   Thu Jul 18 15:09:56 2024 -0400

    Revert "Runtime gtest infrastructure (#122)" (#198)

    This reverts commit 1a581df.

commit 1a581df
Author: Jackson Nie <jnie@tenstorrent.com>
Date:   Thu Jul 18 13:53:32 2024 -0400

    Runtime gtest infrastructure (#122)

    * Initial cmake changes for runtime gtest infra

    * Update instantiation of TTNN_LIBRARY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svuckovicTT svuckovicTT svuckovicTT approved these changes

@odjuricicTT odjuricicTT odjuricicTT left review comments

@nsmithtt nsmithtt nsmithtt approved these changes

@sdjordjevicTT sdjordjevicTT Awaiting requested review from sdjordjevicTT sdjordjevicTT is a code owner

@nobradovictt nobradovictt Awaiting requested review from nobradovictt

@mrakitaTT mrakitaTT Awaiting requested review from mrakitaTT mrakitaTT is a code owner

Assignees

@rpavlovicTT rpavlovicTT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[dialect conversion] Change TOSA -> TTIR to use dialect conversion API
4 participants
@rpavlovicTT @svuckovicTT @nsmithtt @odjuricicTT