#132: Added ability to load system desc file into mlir tests or defau…

[tapspatel]

…lt to original parameters

[nsmithtt]

One more minor change, (add the static_asserts), but otherwise looks good and we can merge! Thanks

[kmabeeTT]

Hey @tapspatel , a bit new here, but a command I got from Jackson (to generate a flat buffer?) is no longer working for me after this change, does it make sense? Works at the commit before this merge.

./build/bin/ttmlir-opt --ttir-to-ttnn-backend-pipeline test/ttmlir/Dialect/TTNN/simple_subtract.mlir | ./build/bin/ttmlir-translate --ttnn-to-flatbuffer -o out.ttnn
ttmlir-opt: /localdev/kmabee/mlir1/lib/Dialect/TTIR/Transforms/Passes.cpp:44: virtual void mlir::tt::ttir::TTIRImplicitDevice::runOnOperation(): Assertion `module->hasAttr(tt::SystemDescAttr::name)' failed.


PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0.      Program arguments: ./build/bin/ttmlir-opt --ttir-to-ttnn-backend-pipeline test/ttmlir/Dialect/TTNN/simple_subtract.mlir
 #0 0x00007f51de3f3a0b llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/opt/ttmlir-toolchain/lib/libLLVM.so.18.1rc+0xf41a0b)
 #1 0x00007f51de3f1b6e llvm::sys::RunSignalHandlers() (/opt/ttmlir-toolchain/lib/libLLVM.so.18.1rc+0xf3fb6e)
 #2 0x00007f51de3f2d39 SignalHandler(int) Signals.cpp:0:0
 #3 0x00007f51e93a4420 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x14420)
 #4 0x00007f51dcfb500b raise (/lib/x86_64-linux-gnu/libc.so.6+0x4300b)
 #5 0x00007f51dcf94859 abort (/lib/x86_64-linux-gnu/libc.so.6+0x22859)
 #6 0x00007f51dcf94729 (/lib/x86_64-linux-gnu/libc.so.6+0x22729)
 #7 0x00007f51dcfa5fd6 (/lib/x86_64-linux-gnu/libc.so.6+0x33fd6)
 #8 0x000055627d46ea72 mlir::tt::ttir::TTIRImplicitDevice::runOnOperation() (./build/bin/ttmlir-opt+0x27f3a72)
 #9 0x000055627d58b7c2 void llvm::function_ref<void ()>::callback_fn<mlir::detail::OpToOpPassAdaptor::run(mlir::Pass*, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int)::'lambda0'()>(long) Pass.cpp:0:0
#10 0x000055627d58a1c4 mlir::detail::OpToOpPassAdaptor::run(mlir::Pass*, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int) (./build/bin/ttmlir-opt+0x290f1c4)
#11 0x000055627d58a34a mlir::detail::OpToOpPassAdaptor::runPipeline(mlir::OpPassManager&, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int, mlir::PassInstrumentor*, mlir::PassInstrumentation::PipelineParentInfo const*) (./build/bin/ttmlir-opt+0x290f34a)
#12 0x000055627d58a4a5 mlir::PassManager::runPasses(mlir::Operation*, mlir::AnalysisManager) (./build/bin/ttmlir-opt+0x290f4a5)
#13 0x000055627d58a78c mlir::PassManager::run(mlir::Operation*) (./build/bin/ttmlir-opt+0x290f78c)
#14 0x000055627cad6924 performActions(llvm::raw_ostream&, std::shared_ptr<llvm::SourceMgr> const&, mlir::MLIRContext*, mlir::MlirOptMainConfig const&) MlirOptMain.cpp:0:0
#15 0x000055627cad6e00 processBuffer(llvm::raw_ostream&, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, mlir::MlirOptMainConfig const&, mlir::DialectRegistry&, llvm::ThreadPool*) MlirOptMain.cpp:0:0
#16 0x000055627cad6ee0 mlir::LogicalResult llvm::function_ref<mlir::LogicalResult (std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&)>::callback_fn<mlir::MlirOptMain(llvm::raw_ostream&, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, mlir::DialectRegistry&, mlir::MlirOptMainConfig const&)::'lambda'(std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&)>(long, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&) MlirOptMain.cpp:0:0
#17 0x000055627d6bccfb mlir::splitAndProcessBuffer(std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::function_ref<mlir::LogicalResult (std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&)>, llvm::raw_ostream&, bool, bool) (./build/bin/ttmlir-opt+0x2a41cfb)
#18 0x000055627cad3e74 mlir::MlirOptMain(llvm::raw_ostream&, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, mlir::DialectRegistry&, mlir::MlirOptMainConfig const&) (./build/bin/ttmlir-opt+0x1e58e74)
#19 0x000055627cad70e7 mlir::MlirOptMain(int, char**, llvm::StringRef, llvm::StringRef, mlir::DialectRegistry&) (./build/bin/ttmlir-opt+0x1e5c0e7)
#20 0x000055627cad727b mlir::MlirOptMain(int, char**, llvm::StringRef, mlir::DialectRegistry&) (./build/bin/ttmlir-opt+0x1e5c27b)
#21 0x000055627bbea7e5 main (./build/bin/ttmlir-opt+0xf6f7e5)
#22 0x00007f51dcf96083 __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x24083)
#23 0x000055627bbea6de _start (./build/bin/ttmlir-opt+0xf6f6de)
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.

[tapspatel]

@kmabeeTT hey sorry you need to add this pass: --ttir-load-system-desc. I'll add it into the pipeline