Runtime support for RuntimeArgs on KernelDesc (Tensor Addr + Semaphores) #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmabeeTT
requested review from
jnie-TT,
AleksKnezevic,
tapspatel and
nsmithtt
as code owners
nsmithtt
approved these changes
Sep 9, 2024
…es) #361/#267 - 2 types of runtime_args today: RuntimeArgTensorAddress, RuntimeArgSemaphoreAddress where runtime will resolve tensor address or semaphore id, and call metal APIs SetRuntimeArgs() and CreateSemaphore() - Compiler support not included, so did some light testing with various dummy values for each type in flatbuffer via TTMetalToFlatbuffer.cpp changes, and tested assertions. For now, keep nullptr in .ttm for runtime_args and runtime_args_types
kmabeeTT
force-pushed
the
kmabee/issue_361_rt_args
branch
from
0d90c69 to
8c636ae
Compare
uazizTT
pushed a commit
that referenced
this pull request
Sep 12, 2024
…es) #361/#267 (#650) - 2 types of runtime_args today: RuntimeArgTensorAddress, RuntimeArgSemaphoreAddress where runtime will resolve tensor address or semaphore id, and call metal APIs SetRuntimeArgs() and CreateSemaphore() - Compiler support not included, so did some light testing with various dummy values for each type in flatbuffer via TTMetalToFlatbuffer.cpp changes, and tested assertions. For now, keep nullptr in .ttm for runtime_args and runtime_args_types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #361 and Closes #267
2 types of runtime_args today: RuntimeArgTensorAddress, RuntimeArgSemaphoreAddress where runtime will resolve tensor address or semaphore id, and call metal APIs SetRuntimeArgs() and CreateSemaphore()
Compiler support not included, so did some light testing with various dummy values for each type in flatbuffer via TTMetalToFlatbuffer.cpp changes, and tested assertions. For now, keep nullptr in .ttm for runtime_args and runtime_args_types