[Minor] Negative dim support for concat
#651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mtopalovicTT
commented
Sep 8, 2024
•
mtopalovicTT
commented
- Torch supports it. Forge passes negative dim attr for concat.
- Added more positive and negative tests.
Torch supports it. Forge passes negative dim attr for concat.
mtopalovicTT
requested review from
sdjordjevicTT,
rpavlovicTT,
nobradovictt,
mrakitaTT and
nsmithtt
as code owners
mtopalovicTT
changed the title
concatconcat
nsmithtt
approved these changes
Sep 9, 2024
| @@ -173,9 +173,14 @@ class ConcatOpConversionPattern : public OpConversionPattern<ttir::ConcatOp> { | |||
| LogicalResult | |||
| matchAndRewrite(ttir::ConcatOp op, OpAdaptor adaptor, | |||
| ConversionPatternRewriter &rewriter) const override { | |||
| int dim = adaptor.getDim(); | |||
There was a problem hiding this comment.
Can you elaborate on why we convert from negative to positive dim in TTIR to TTNN conversion? Do we want both dialects to support the negative dim?
uazizTT
pushed a commit
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.