Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine workflows #668

Merged
merged 11 commits into from
Sep 13, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ jobs:
create-symlink: true
key: ${{ matrix.build.runs-on }}-run-ON-perf-${{ matrix.build.enable_perf }}-${{ env.SDK_VERSION }}

# Build project

- name: Configure CMake
shell: bash
run: |
Expand All @@ -69,6 +71,33 @@ jobs:
cmake --build ${{ steps.strings.outputs.build-output-dir }}
cmake --install ${{ steps.strings.outputs.build-output-dir }} --component Test

- name: Lint
shell: bash
run: |
source env/activate
cmake --build ${{ steps.strings.outputs.build-output-dir }} -- clang-tidy
vmilosevic marked this conversation as resolved.
Show resolved Hide resolved

- name: Run Test
shell: bash
run: |
source env/activate
cmake --build ${{ steps.strings.outputs.build-output-dir }} -- check-ttmlir

- name: Upload Test Report
uses: actions/upload-artifact@v4
with:
name: test-reports-${{ matrix.build.runs-on }}
path: build/test/report.xml

- name: Show Test Report
uses: mikepenz/action-junit-report@v4
if: success() || failure()
with:
report_paths: build/test/report.xml
check_name: MLIR Tests

# Build and upload ttrt

- name: Build ttrt
shell: bash
run: |
Expand Down Expand Up @@ -106,6 +135,9 @@ jobs:
echo "version=$version" >> $GITHUB_ENV
echo $version


# Run tests on TT hardware

run-tests:

timeout-minutes: 30
Expand All @@ -116,9 +148,8 @@ jobs:
build: [
{runs-on: n150, enable_perf: OFF, name: "run"},
{runs-on: n150, enable_perf: ON, name: "perf"},
{runs-on: n300, enable_perf: OFF, name: "run"},
#TODO re-enable #648
#{runs-on: n300, enable_perf: ON, name: "perf"},
{runs-on: n300, enable_perf: OFF, name: "run"},
{runs-on: n300, enable_perf: ON, name: "perf"},
]

runs-on:
Expand Down
91 changes: 0 additions & 91 deletions .github/workflows/docker-build.yml

This file was deleted.

3 changes: 0 additions & 3 deletions .github/workflows/on-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ jobs:
macos-build:
uses: ./.github/workflows/macos-build.yml
secrets: inherit
docker-build:
uses: ./.github/workflows/docker-build.yml
secrets: inherit
build-and-test:
uses: ./.github/workflows/build-and-test.yml
secrets: inherit
3 changes: 0 additions & 3 deletions .github/workflows/on-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ jobs:
macos-build:
uses: ./.github/workflows/macos-build.yml
secrets: inherit
docker-build:
uses: ./.github/workflows/docker-build.yml
secrets: inherit
build-and-test:
uses: ./.github/workflows/build-and-test.yml
secrets: inherit
3 changes: 1 addition & 2 deletions cmake/modules/LintTools.cmake
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# clang-tidy setup
add_custom_target(run-clang-tidy-install COMMAND cp ${TTMLIR_TOOLCHAIN_DIR}/src/llvm-project/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py ${TTMLIR_TOOLCHAIN_DIR}/bin/)
add_custom_target(clang-tidy-filter-out-external-srcs COMMAND python3 ${TTMLIR_SOURCE_DIR}/tools/scripts/filter-compile-commands.py ${TTMLIR_BINARY_DIR}/compile_commands.json ${TTMLIR_SOURCE_DIR})
add_custom_target(clang-tidy COMMAND run-clang-tidy.py -p ${PROJECT_BINARY_DIR} -warnings-as-errors '*' DEPENDS clang-tidy-filter-out-external-srcs run-clang-tidy-install)
add_custom_target(clang-tidy COMMAND run-clang-tidy.py -p ${PROJECT_BINARY_DIR} -warnings-as-errors '*' DEPENDS clang-tidy-filter-out-external-srcs)
vmilosevic marked this conversation as resolved.
Show resolved Hide resolved
add_custom_target(clang-format COMMAND git-clang-format)
Loading