Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update output tensors in from device op #776

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Update output tensors in from device op #776

merged 2 commits into from
Sep 20, 2024

Conversation

jnie-TT
Copy link
Contributor

@jnie-TT jnie-TT commented Sep 19, 2024

Fixes main CI where all output tensors are 0

@jnie-TT jnie-TT requested a review from nsmithtt September 19, 2024 22:48
@nsmithtt
Copy link
Contributor

Can you make the change that moves the ttrt flag to the correct job?

@jnie-TT jnie-TT requested a review from vmilosevic as a code owner September 20, 2024 01:17
@jnie-TT
Copy link
Contributor Author

jnie-TT commented Sep 20, 2024

Merging as we need this to get CI green

@jnie-TT jnie-TT merged commit 04a7441 into main Sep 20, 2024
12 checks passed
nsmithtt added a commit that referenced this pull request Sep 20, 2024
@nsmithtt
Partial revert 19732d0
d6590f5 
The to_layout/from_device was causing the following fallout:
- #779
- #788
- All zeros output, separately addressed #776

For now just reverting back to to_memory_config.
@nsmithtt nsmithtt mentioned this pull request Sep 20, 2024
Merged
nsmithtt added a commit that referenced this pull request Sep 20, 2024
@nsmithtt
Partial revert 19732d0 (#789)
f4cdd80 
The to_layout/from_device was causing the following fallout:
- #779
- #788
- All zeros output, separately addressed #776

For now just reverting back to to_memory_config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsmithtt nsmithtt nsmithtt approved these changes

@kmabeeTT kmabeeTT Awaiting requested review from kmabeeTT kmabeeTT is a code owner

@AleksKnezevic AleksKnezevic Awaiting requested review from AleksKnezevic AleksKnezevic is a code owner

@pilkicTT pilkicTT Awaiting requested review from pilkicTT pilkicTT is a code owner

@vmilosevic vmilosevic Awaiting requested review from vmilosevic vmilosevic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnie-TT @nsmithtt