Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in stablehlo reduce op conversion #899

Closed
wants to merge 1 commit into from

Conversation

mmanzoorTT
Copy link
Contributor

@mmanzoorTT mmanzoorTT commented Oct 10, 2024

fixes #848

Copy link
Contributor

@uazizTT uazizTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @mrakitaTT already made some fixes in this commit

df424f2

Copy link
Contributor

@mrakitaTT mrakitaTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline with Asif and Aleks, just to document the conclusions.

This is already tracked with #805, I've wrote there the current situation: #805 (comment)

I will escalate this metal issue in TTNN Op Bugs/WAs component and discuss if we can make the workaround since it doesn't seem likely that Metal team will fix this on their side.

If we decide to make a workaround, then I would rather close this PR and send the PR with the fixes that I've already made here and here, because they cover this issue more generally. Fix that Asif made is working only for full reduce (across all dimensions).

Let's leave this PR open in case that we decide to wait on Metal team, because we can still support the specific case that Asif fixed without it being "workaround", though I would make a few changes to the code in that case.

@mmanzoorTT mmanzoorTT force-pushed the mmanzoor/fix-reduce-op branch from e229b21 to 30ab6bf Compare October 24, 2024 19:30
@mmanzoorTT mmanzoorTT closed this Jan 22, 2025
@mmanzoorTT mmanzoorTT deleted the mmanzoor/fix-reduce-op branch February 10, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[StableHLO] Reduce op failure
5 participants