Docker build as part of workflow #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsmithtt
approved these changes
Oct 17, 2024
.github/get-docker-tag.sh
Outdated
| # Calculate hash from the following files. This hash is used to tag the docker images. | ||
| # Any change in these files will result in a new docker image build | ||
| DOCKERFILE_HASH_FILES=".github/Dockerfile.base .github/Dockerfile.ci .github/Dockerfile.ci env/CMakeLists.txt" | ||
| DOCKERFILE_HASH=$(md5sum $DOCKERFILE_HASH_FILES | md5sum | cut -d ' ' -f 1) |
There was a problem hiding this comment.
Ok, this will make slightly longer tags, but it's ok we don't hit any length limitations
dt-e931311c5edde3f3df8df7b8bf42e9dd
dt-8d11f16163457c4007e6c21d000dee14c80887131e4dce6a3b34f106e25ea344
This was referenced Oct 18, 2024
This was referenced Oct 21, 2024
vmilosevic
added a commit
to tenstorrent/tt-forge-fe
that referenced
this pull request
Oct 24, 2024
Build docker image as part of a workflow Similar to : tenstorrent/tt-mlir#928
vmilosevic
added a commit
to tenstorrent/tt-xla
that referenced
this pull request
Nov 22, 2024
Build docker image as part of a workflow Similar to : tenstorrent/tt-mlir#928 Docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m updating the workflow to make the Docker image build the first step in the build and test pipeline. Instead of triggering Docker builds manually, the workflow will check if the required Docker images already exist on GHCR (GitHub Container Registry). If they don’t, the workflow will initiate the build.
How do we determine which Docker image is needed?
The image tag is based on a hash of the Dockerfiles and the environment CMake file. If any of these change, a new Docker image build will be triggered. Although we could refine this to only trigger builds for specific changes (e.g., LLVM version in the environment file), for now, any change will trigger a new build. See
get-docker-tag.shIf a Docker image with the calculated tag already exists, the job will quickly complete and pass the image tag to the subsequent build and test jobs, which will use this specific image instead of the "latest" tag. This ensures the workflow always uses the correct Docker image.
How do we know which image to use in IRD?
Each time a Docker image is built, it will also be tagged as "latest." In most cases, this "latest" image will work for IRD. However, if it doesn’t, developers can run the
get-docker-tag.shscript to retrieve the exact image tag needed for their code and use that in IRD.Docs