Create cluster descriptor yaml in hidden folder #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tt-vjovanovic FYI, related to https://github.com/tenstorrent/tt-debuda/pull/165 |
|
@tt-vjovanovic and @abhullar-tt, please suggest how can we do this in other ways if this is not acceptable. |
|
Chatted offline with @tt-vjovanovic , and I changed the code as it is in tt-debuda, created in temp dir: https://github.com/tenstorrent/tt-debuda/blob/main/ttlens/server/lib/src/umd_with_open_implementation.cpp#L35 |
joelsmithTT
approved these changes
Nov 13, 2024
broskoTT
added a commit
that referenced
this pull request
Nov 13, 2024
### Issue Fixes #298 ### Description After #245 the default location of cluster_descriptor.yaml creation has changed. There were some comments from metal and debuda team around this. Mainly, this file is not hidden anymore. On the suggestion from @tt-vjovanovic , I've changed the code to create this file in OS provided temporary directory. ### List of the changes - Put newly created cluster_descriptor.yaml in a temp folder. This won't be relative to working dir anymore. ### Testing CI tests touch this codepath ### API Changes There are no API changes in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #298
Description
After #245 the default location of cluster_descriptor.yaml creation has changed. There were some comments from metal and debuda team around this. Mainly, this file is not hidden anymore.
On the suggestion from @tt-vjovanovic , I've changed the code to create this file in OS provided temporary directory.
List of the changes
Testing
CI tests touch this codepath
API Changes
There are no API changes in this PR.