Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pcc allclose tunable for each test. Add test for MLP training. #189

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

umalesTT
Copy link
Contributor

When tensors are too close, pcc will output NaN values. Therefore, for each test it should be possible to separately tune the threshold of allclose.rtol and allclose.atol below which pcc won't be calculated and therefore test will be able to pass.

This is applied in test for MLP neural network training with MSE loss and SGD optimizer.

Copy link

github-actions bot commented Jan 24, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-XLA Tests457 ran390 passed67 skipped0 failed
TestResult
No test annotations available

tests/infra/comparison.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.03%. Comparing base (1b68a3c) to head (f3236bb).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   77.03%   77.03%           
=======================================
  Files          21       21           
  Lines        1006     1006           
=======================================
  Hits          775      775           
  Misses        231      231           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@umalesTT umalesTT merged commit 54e1f57 into main Jan 31, 2025
6 checks passed
@umalesTT umalesTT deleted the umales/mnist_mse branch January 31, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants