Make pcc allclose tunable for each test. Add test for MLP training. #189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tensors are too close, pcc will output NaN values. Therefore, for each test it should be possible to separately tune the threshold of allclose.rtol and allclose.atol below which pcc won't be calculated and therefore test will be able to pass.
This is applied in test for MLP neural network training with MSE loss and SGD optimizer.