Setup Codecov #193
Closed
Setup Codecov #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goshlanguage
requested review from
ajakovljevicTT,
kmitrovicTT and
mrakitaTT
as code owners
goshlanguage
force-pushed
the
rhartje/codecov
branch
from
421eed0 to
3b2abdb
Compare
|
||||||||||||||
kmitrovicTT
approved these changes
Jan 28, 2025
|
@goshlanguage tnx for providing this! Please wait on Marko's response on this. @mrakitaTT @ajakovljevicTT what do we think about adding cpp coverage as well? Would it make sense to have coverage of our pjrt plugin code? |
|
I connected with @vmilosevic who already setup Closing this PR as python coverage is likely not the right choice for this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
No issue, but happy to make one if it makes sense
Problem description
This PR aims to add codecov to the repo to give a report for how each PR affects the test coverage of the project.
Currently, the PR only leverages python's pytest coverage, but if it makes sense for the C++ code, we can leverage either
gcovorlcovsuch as in https://about.codecov.io/language/c-plus-plus/What's changed
Add a Github action to upload the coverage xml to codecov so it can generate reports per PR
Checklist