Uplift mlir and add shardy to dependencies #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgligorijevicTT
requested review from
ajakovljevicTT,
kmitrovicTT and
mrakitaTT
as code owners
|
FYI @wooseokTT |
|
||||||||||||||
kmitrovicTT
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
You have some tests failing. I have changed tests for convert in #168. Maybe wait for that to be merged before debugging.
third_party/CMakeLists.txt
Outdated
| @@ -3,7 +3,7 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
| # | |||
|
|
|||
| set(TT_MLIR_VERSION "ad93092841542d104b8bacba6b92d97678ccd94e") | |||
| set(TT_MLIR_VERSION "73efb5cd3e25215d3ee23c5af39c0b5dfe200a28") | |||
There was a problem hiding this comment.
Update this to the newest possible after you get approvals.
|
I see we have the same fail in https://github.com/tenstorrent/tt-xla/actions/runs/13009237972/job/36284256159. Let me check this, I think I know what the problem may be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Problem description
tt-xla fails to build with newer tt-mlir versions that depend on shardy
What's changed
This PR updates cmake files to correctly include shardy.
Checklist