Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a stable set for schema directories #1086

Merged
merged 3 commits into from
Sep 30, 2020

Conversation

dominiklohmann
Copy link
Member

No description provided.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Sep 30, 2020
@dominiklohmann dominiklohmann requested a review from a team September 30, 2020 15:33
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one more thing we should consider:
With the current design, the user has no way to give a higher priority to one of the predefined directories.
Consider vast --schema-paths=[/usr/share/vast/schema]. The given path would still get lower priority than the xdg ones.

@dominiklohmann
Copy link
Member Author

dominiklohmann commented Sep 30, 2020

With the current design, the user has no way to give a higher priority to one of the predefined directories.

That is not true, we still have --no-default-schema to disable the default paths.

We can also change the insertion order such that user dirs are put first in the order. I'll gladly make that change, because I think that makes more sense anyways.

@tobim
Copy link
Member

tobim commented Sep 30, 2020

That is not true, we still have --no-default-schema to disable the default paths.

I forgot about that.

We can also change the insertion order such that user dirs are put first in the order. I'll gladly make that change, because I think that makes more sense anyways.

I prefer it the way it is now, we should assume that the user knows what they're doing.

@dominiklohmann dominiklohmann merged commit 5c61ec3 into master Sep 30, 2020
@dominiklohmann dominiklohmann deleted the topic/schema-directory-order branch September 30, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants