Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Subscribe multiple topics with a single subscription #120

Merged
merged 4 commits into from
May 18, 2021
Merged

Conversation

0snap
Copy link
Contributor

@0snap 0snap commented May 18, 2021

📔 Description

Subscribers can now subscribe for multiple Threat Bus topics by sending a single Subscription message. That is of advantage to the previous implementation, because subscribers now only get to deal with a single p2p_topic for their subscription instead of one p2p_topic per subscribed Threat Bus topic.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/threatbus, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

  • Run the integration tests
  • Use the zmq_sender and zmq_receiver in tests/utils for interactive testing

@0snap 0snap requested review from tobim, lava and rolandpeelen and removed request for tobim May 18, 2021 13:19
@0snap 0snap added the feature New functionality label May 18, 2021
Copy link

@rolandpeelen rolandpeelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the code and it looks good from that perspective 🚀 . Did not run this though.

@0snap 0snap merged commit 67ffbac into master May 18, 2021
@0snap 0snap deleted the story/ch25105 branch May 18, 2021 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants