This repository has been archived by the owner on May 29, 2024. It is now read-only.
Unpin stix2 and fix breaking changes #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lava
force-pushed
the
story/ch27394/stix3-update
branch
2 times, most recently
from
b1494db to
e6b9cc1
Compare
added 2 commits
August 23, 2021 20:33
This function was removed upstream from STIX 3.0 in 2cda97cf5e51403c43a96ceb9073afab7706638a, since it apparently became obsolete.
lava
force-pushed
the
story/ch27394/stix3-update
branch
from
e6b9cc1 to
59ebf76
Compare
rolandpeelen
approved these changes
Aug 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
The
StixBase::object_properties()method was removed in stix 3.0 on charges of being obsolete, breaking our code.This PR removes the calls to
object_properties()analogous to how it was done in the linked upstream PR, and bumps the minimum dependency version to 3.0 since making these changes will break compatibility with stix 2.x,📝 Checklist
🎯 Review Instructions