Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Generate a valid UUIDv4 for the dummy sighting reference #178

Merged
merged 3 commits into from
Dec 14, 2021
Merged

Generate a valid UUIDv4 for the dummy sighting reference #178

merged 3 commits into from
Dec 14, 2021

Conversation

lava
Copy link
Member

@lava lava commented Dec 13, 2021 •
edited
Loading

📔 Description

  • Use valid UUIDv4 for sighting dummy uuid
  • Don't discard matched event as sighting context
  • Add CHANGELOG entry for misp bugfix

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/threatbus, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

@lava lava force-pushed the topic/note-uuidv4 branch 3 times, most recently from a6a6586 to 186814c Compare December 14, 2021 17:28
@lava lava enabled auto-merge December 14, 2021 17:50
mavam
mavam approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have a chance to test this, but the logic appears correct.

apps/vast/vast_threatbus/message_mapping.py Show resolved Hide resolved
@lava lava force-pushed the topic/note-uuidv4 branch from 186814c to 91f9eaf Compare December 14, 2021 20:20
@lava lava merged commit 6f21d01 into master Dec 14, 2021
@lava lava deleted the topic/note-uuidv4 branch December 14, 2021 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mavam mavam mavam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lava @mavam