This repository has been archived by the owner on May 29, 2024. It is now read-only.
Fix thread termination behavior for Python <= 3.7.3 #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This PR fixes a bug that was introduced with #61
This bug caused Threat Bus to terminate directly after startup in Python 3.7.3 and earlier. A detailed description of the issue can be found in this Stackoverflow post.
📝 Checklist
Not needed: This fixes an unreleased bug and a Changelog entry for the desired behavior already exists.
🎯 Review Instructions
Commit-by-commit
Test this as follows:
make dev-mode
in both envsconfig.yaml.example
venv/bin/threatbus -c config.yaml
in each env (one at a time, else they try to use the same ports)ctrl+c