generated from pitmonticone/LeanProject
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Massive generation of refutations via polynomials over Z/nZ #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Sep 27, 2024
Hmm, the blueprint CI broke. I think I’ll wait for the overall discussion around file structure to settle before continueing here. Anyone is welcome to pick it up though. |
nomeata
force-pushed
the
finite_poly_refutation
branch
from
September 27, 2024 16:45
1dc3cce
to
558fd3b
Compare
nomeata
force-pushed
the
finite_poly_refutation
branch
from
September 27, 2024 16:56
558fd3b
to
e94af2b
Compare
dwrensha
reviewed
Sep 27, 2024
…into finite_poly_refutation
pitmonticone
added
do-not-merge
This PR is not meant to be merged
and removed
do-not-merge
This PR is not meant to be merged
labels
Sep 29, 2024
nomeata
added a commit
that referenced
this pull request
Sep 29, 2024
this extracts the “infrastructure” built in #19 into its own PR. In particular * The `Facts G [1,2] [3,4]` syntax to concisely and efficiently state that G satisfies Equation1 and Equation2, but not Equation3 and Equation4 There is also a crude `calculate_facts` command that takes a magma and an instance and a tactic and lists those for which the tactic succeeds. * The `decideFin!` tactic that is a bit like `decide` but simply believes that the statement is true, so that the check only happens by the kernel, and uses custom code to construct the `Decidable` instance for the kind of theorems we actually encounter, to avoid the (slow) type inference. * The `memoFinOp` elaborator that take a function `Fin n → Fin n → Fin n`, tabulates it, encodes this table in a single number and implements the lookup based on that. Presumably that's more compact and faster to evaluate by `decide` than other forms (array indexing, polynomials etc.)
nomeata
force-pushed
the
finite_poly_refutation
branch
from
September 29, 2024 17:44
e823eb1
to
eee78e9
Compare
Should be merged after #110 only. |
…ite_poly_refutation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a large number of automatically generated refutations by @carlini in https://github.com/carlini/equational_theories. All of them are magmas over Z/nZ with a polynomial of degree ≤2 as the operations.
For now, until we know better what to actually run, I excluded all magmas with 6 or more elements, just to keep this PR sizable.