Fix teragrep exec syslog stream command not working with subsequent commands when using host and port parameters #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemhu
approved these changes
Aug 14, 2024
kortemik
requested changes
Aug 21, 2024
… and use the name as prefix in the tokens in that mode
kortemik
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66.
Basically the issue was that the port number was recognizable only in the grammar mode "COMMAND_TERAGREP_MODE_IP", but when the parser read it, it didn't pop the grammar mode back to the mode where it can recognize other tokens again (like the pipe token).
Created unit tests for the command and refactored the whole unit test file to not throw exceptions in tests because that is not good practice.