Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create pull_request_template.md #223

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create pull_request_template.md #223

wants to merge 1 commit into from

Conversation

ronja-ui
Copy link
Contributor

@ronja-ui ronja-ui commented Sep 5, 2024

added PR template

@ronja-ui ronja-ui self-assigned this Sep 5, 2024
@ronja-ui ronja-ui added the review label Sep 9, 2024
kortemik
kortemik requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@kortemik kortemik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rat plugin needs an exception

@ronja-ui
Copy link
Contributor Author

ronja-ui commented Oct 1, 2024

rat plugin needs an exception

Doesn't the following line exclude everything, including pull request directory, in .github directory?

<!-- ci -->
 <exclude>.github/**</exclude>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kortemik kortemik kortemik requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@ronja-ui ronja-ui

Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronja-ui @kortemik