Move config stuff to own Config class, cleanup readme about logging c… #15
Conversation
| keystorePassword = System.getProperty("tlsKeystorePassword", "changeit"); | ||
| } | ||
|
|
||
| public InputStream getKeystoreStream() throws IOException { |
There was a problem hiding this comment.
this is poperational code and should not be part of the config as config should not contain executable code.
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| } | ||
| public Config() { | ||
| try { | ||
| port = Integer.parseInt(System.getProperty("port", "1601")); |
There was a problem hiding this comment.
StaticAssignmentInConstructor: This assignment is to a static field. Mutating static state from a constructor is highly error-prone.
❗❗ 2 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| src/main/java/com/teragrep/rlp_07/Config.java | 33 |
| src/main/java/com/teragrep/rlp_07/Config.java | 34 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
| } | ||
| isTls = Boolean.parseBoolean(System.getProperty("tls", "false")); | ||
| keystorePassword = System.getProperty("tlsKeystorePassword", "changeit"); | ||
| keystorePath = System.getProperty("tlsKeystore", null); |
There was a problem hiding this comment.
StaticAssignmentInConstructor: This assignment is to a static field. Mutating static state from a constructor is highly error-prone.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
| LOGGER.info("Starting TLS server on port " + config.getPort()); | ||
|
|
||
| String keystorePath = config.getKeystorePath(); | ||
| InputStream keystoreStream; | ||
| if(keystorePath != null) { | ||
| LOGGER.info("Using user supplied keystore"); | ||
| Path path = Paths.get(keystorePath); |
There was a problem hiding this comment.
PATH_TRAVERSAL_IN: This API (java/nio/file/Paths.get(Ljava/lang/String;[Ljava/lang/String;)Ljava/nio/file/Path;) reads a file whose location might be specified by user input
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
…onfigs