-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework node version tags workflow #33
Conversation
Rename this PR to match what it does I had meant for you to build a single image and tag it with multiple tags, somewhat like this:
Instead you are doing this, we won't end up with the right versions in these tags ...
We always want to have the latest major node version at build time. See if you can rework this. |
This PR is meant to address the first part of this issue: terascope/teraslice#3683 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Co-authored-by: Austin Godber <godber@terascope.io>
I'm going to go on record here and point out that we were burned by the major number |
This PR makes the following changes:
terascope/node-base-core
imagesv3
tov4
v2
tov3
v2
tov3
v4
tov6
node_version
kafka_connector_version
Ref to issue terascope/teraslice#3683