Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework node version tags workflow #33

Merged
merged 15 commits into from
Jul 18, 2024
Merged

Rework node version tags workflow #33

merged 15 commits into from
Jul 18, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Jul 15, 2024

This PR makes the following changes:

  • Important: Removed the building and publishing of terascope/node-base-core images
    • This is because there isn't a known use-case for this image
  • Updated the following github actions:
    • actions/checkout from v3 to v4
    • docker/login-action from v2 to v3
    • docker/setup-buildx-action from v2 to v3
    • docker/build-push-action from v4 to v6
  • Added new workflow that will build and update image tags based off of the latest major node versions
  • Added the following labels to the image:
    • node_version
    • kafka_connector_version

Ref to issue terascope/teraslice#3683

@sotojn sotojn self-assigned this Jul 15, 2024
@godber
Copy link
Member

godber commented Jul 15, 2024

Rename this PR to match what it does

I had meant for you to build a single image and tag it with multiple tags, somewhat like this:

docker build 22.2.0
docker tag 22.2.0 22.2
docker tag 22.2.0 22
docker push 22.2.0
docker push 22.2
docker push 22

Instead you are doing this, we won't end up with the right versions in these tags ...

docker build 22.2.0 
docker push 22.2.0  <- 22.2.0
docker build 22.2
docker push 22.2     <- 22.2.?
docker build 22        <- 22.4.1
docker push 22  

We always want to have the latest major node version at build time. See if you can rework this.

@sotojn sotojn changed the title Migrate docker images to ghcr registry Rework node version tags workflow Jul 16, 2024
@godber
Copy link
Member

godber commented Jul 16, 2024

This PR is meant to address the first part of this issue: terascope/teraslice#3683

@sotojn sotojn changed the title Rework node version tags workflow [Draft] Rework node version tags workflow Jul 16, 2024
@sotojn sotojn changed the title [Draft] Rework node version tags workflow Rework node version tags workflow Jul 16, 2024
@sotojn sotojn marked this pull request as draft July 16, 2024 22:51
@sotojn sotojn marked this pull request as ready for review July 16, 2024 23:48
@sotojn sotojn requested review from godber and busma13 July 17, 2024 16:34
Copy link
Contributor

@busma13 busma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

.github/workflows/build.yml Outdated Show resolved Hide resolved
sotojn and others added 2 commits July 18, 2024 13:16
Co-authored-by: Austin Godber <godber@terascope.io>
@godber
Copy link
Member

godber commented Jul 18, 2024

I'm going to go on record here and point out that we were burned by the major number 22 before we even managed to merge this PR. Yesterday everything was fine, today, 22.5.0 came out and broke the kafka install, so we've pinned 22 -> 22.4.1. We will need to remember to address the issue and then come back and unpin it.

@godber godber merged commit 25fb908 into master Jul 18, 2024
3 checks passed
@godber godber deleted the migrate-to-ghcr-registry branch July 18, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants