Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file asset api client exports #1048

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Fix file asset api client exports #1048

merged 6 commits into from
Aug 23, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Aug 23, 2024

This PR makes the following changes:

  • Renames client-types directory to client-helpers
  • Changes exports to export full classes instead of just types
    • This fixes a bug in teraslice that needs lower level s3-client error classes to function
  • Bumps @terascope/file-asset-apis from v1.0.0 to v1.0.1

Ref to issue #1047

@sotojn sotojn requested review from jsnoble and busma13 August 23, 2024 17:42
@sotojn sotojn self-assigned this Aug 23, 2024
jsnoble
jsnoble approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@jsnoble jsnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnoble jsnoble merged commit fb61f40 into master Aug 23, 2024
7 checks passed
@jsnoble jsnoble deleted the fix-file-asset-apis-type-bug branch August 23, 2024 19:26
@godber godber mentioned this pull request Sep 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnoble jsnoble jsnoble approved these changes

@busma13 busma13 Awaiting requested review from busma13

Assignees

@sotojn sotojn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sotojn @jsnoble