You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The official client looks well documented and maintained and appears to have the simple things I have needed so far, so I think it makes sense to switch to this in the long run. Unless there's progress in the go-daddy client before we get to switching.
The text was updated successfully, but these errors were encountered:
This PR makes the following changes:
- Creates a `kubernetesV2` directory under
`packages/teraslice/src/lib/cluster/services/cluster/backends` with
copies of all files in `kubernetes` directory
- Modify `K8s` class to use `@kubernetes/client-node` instead of
`kubernetes-client`
- Modify `index.ts`:
- Rename class `KubernetesClusterBackendV2`
- Account for typed responses from new client
- Account for `kubernetesV2` possibility anywhere
`cluster_manager_type`, `CLUSTERING_TYPE` or `TEST_PLATFORM` are checked
- Duplicate unit tests related to k8s to run k8sV2 also
- Add e2e-k8s-v2-tests to github workflow
- Update `ts-scripts test` and `ts-scripts k8s-env` to allow for
kubernetesV2 clustering
- Add `clustering-type` and `keep-open` flags to `ts-scripts k8s-env`
- Add k8sV2 script to root package.json
- Add `@terascope/types:0.17.2` as scripts dependency
Ref: #1799
I think I will close this, the new client is present in the Kubernetesv2 backend, we will be experimenting in that code for a bit. Keeping this open won't help anything.
When I started this implementation, there was no official kubernetes client. There is one now:
https://github.com/kubernetes-client/javascript
The client I am using is in the process of switching to using it as it's lower layer as well as other things. See this:
https://github.com/godaddy/kubernetes-client/blob/master/merging-with-kubernetes.md
That work has been held up since November 2019 with the latest word being:
kubernetes-client/javascript#244 (comment)
The official client looks well documented and maintained and appears to have the simple things I have needed so far, so I think it makes sense to switch to this in the long run. Unless there's progress in the go-daddy client before we get to switching.
The text was updated successfully, but these errors were encountered: