Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Teraslice to Official Kubernetes Client #1799

Closed
godber opened this issue Apr 1, 2020 · 2 comments
Closed

Switch Teraslice to Official Kubernetes Client #1799

godber opened this issue Apr 1, 2020 · 2 comments
Assignees
@busma13
Labels
enhancement k8s Applies to Teraslice in kubernetes cluster mode only. pkg/teraslice

Comments

@godber
Copy link
Member

godber commented Apr 1, 2020

When I started this implementation, there was no official kubernetes client. There is one now:

https://github.com/kubernetes-client/javascript

The client I am using is in the process of switching to using it as it's lower layer as well as other things. See this:

https://github.com/godaddy/kubernetes-client/blob/master/merging-with-kubernetes.md

That work has been held up since November 2019 with the latest word being:

kubernetes-client/javascript#244 (comment)

The official client looks well documented and maintained and appears to have the simple things I have needed so far, so I think it makes sense to switch to this in the long run. Unless there's progress in the go-daddy client before we get to switching.
@godber godber added enhancement k8s Applies to Teraslice in kubernetes cluster mode only. pkg/teraslice labels Apr 1, 2020
@godber
Copy link
Member Author

godber commented Nov 16, 2023

This is a high risk change and isn't something we want to do urgently.

@busma13 busma13 mentioned this issue Jun 6, 2024
Merged
godber pushed a commit that referenced this issue Jul 10, 2024
@busma13
k8s v2 backend (#3630)
5817340 
This PR makes the following changes:
- Creates a `kubernetesV2` directory under
`packages/teraslice/src/lib/cluster/services/cluster/backends` with
copies of all files in `kubernetes` directory
- Modify `K8s` class to use `@kubernetes/client-node` instead of
`kubernetes-client`
- Modify `index.ts`:
    - Rename class `KubernetesClusterBackendV2`
    - Account for typed responses from new client
- Account for `kubernetesV2` possibility anywhere
`cluster_manager_type`, `CLUSTERING_TYPE` or `TEST_PLATFORM` are checked
- Duplicate unit tests related to k8s to run k8sV2 also
- Add e2e-k8s-v2-tests to github workflow
- Update `ts-scripts test` and `ts-scripts k8s-env` to allow for
kubernetesV2 clustering
- Add `clustering-type` and `keep-open` flags to `ts-scripts k8s-env`
- Add k8sV2 script to root package.json 
- Add `@terascope/types:0.17.2` as scripts dependency

Ref: #1799
@godber
Copy link
Member Author

godber commented Aug 21, 2024

I think I will close this, the new client is present in the Kubernetesv2 backend, we will be experimenting in that code for a bit. Keeping this open won't help anything.

@godber godber closed this as completed Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busma13 busma13

Labels
enhancement k8s Applies to Teraslice in kubernetes cluster mode only. pkg/teraslice
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@godber @busma13 @sotojn