Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert @swc/core to version 1.4.0 #3661

Merged
merged 1 commit into from
Jun 18, 2024
Merged

revert @swc/core to version 1.4.0 #3661

merged 1 commit into from
Jun 18, 2024

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Jun 17, 2024

When upgrading @swc/core from v1.4.0 to v1.5.5 there was a change that results in source mappings failing. This would print thousands of lines of error messages in out e2e tests, but everything seems to compile okay. To cut down this noise until there is a fix, this PR reverts the @swc/core version back to 1.4.0.

More details and links here: #3655

@busma13 busma13 self-assigned this Jun 17, 2024
@busma13 busma13 marked this pull request as ready for review June 18, 2024 14:28
@busma13 busma13 requested a review from godber June 18, 2024 14:28
@busma13 busma13 added this to the v2.1 milestone Jun 18, 2024
@godber godber requested a review from jsnoble June 18, 2024 15:36
@godber
Copy link
Member

godber commented Jun 18, 2024

@jsnoble I don't know what this tool is, perhaps you do, if so, you think its OK to roll this back until they address the noisy output problem?

Copy link
Member

@jsnoble jsnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godber godber merged commit b54c210 into master Jun 18, 2024
59 checks passed
@godber godber deleted the update-swc-to-fix-errors branch June 18, 2024 15:41
@jsnoble
Copy link
Member

jsnoble commented Jun 18, 2024

swc is a rust typescript compiler that we are using in some cases rather than ts-jest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants