-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy style from labels to bundles. #64
base: master
Are you sure you want to change the base?
Conversation
Thanks for putting together this PR! Overall, the code looks good to me, but my main concerns are about the resulting UI:
|
Agreed, the styling is probably too aggressive. Perhaps copying salient aspects of the label-style to a more-restricted region around the bundle-name would mimic Gmail's existing Label styling without being a detriment to the aesthetics and usability of inboxy. I've updated my master to reflect a more subtle color scheme:
|
The overall look and feel are still a significant departure from Gmail's original styles. I think we should stay away from using gradients, since Gmail mainly uses flat areas of color. As for the colored boxes around the bundle names, these boxes look similar to labels, which makes it seem like a secondary component rather than the main text for those rows. Since we're mainly discussing UI, perhaps we should iterate over it on the Github issue instead of in a PR. Also, it might be quicker to make UI mocks in design software (ex. Figma) than to code up designs, but feel free to use whichever strategy you're most comfortable with. |
@teresa-ou is merging this PR (or otherwise addressing #12) still under consideration? Incorporating the label colors into the bundled view seems to make perfect sense logically, and it's hard to imagine any other logged enhancement making a larger impact visually. In other words, it seems like a very "good" idea. :) |
Are there any plans to move this feature forward? It would be a very nice addition |
@lpakula added this to his fork. https://github.com/lpakula/inboxy |
Fixes #12
Addresses #13