Fix "validate" vs "validator" name issue in docs #407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
When trying to use
prompts
, and copy + pasting from your own documentation, I ran into an exception thrown deep inside theprompts
library:Using your exact first example (or almost exact... I am using native ES6 modules):
This is the result:
When I instead change the key to
validator
(vsvalidate
as shown in the example) then everything works fine.All tests are passing, so I made the assumption that it was the documentation that was wrong. If this assumption is incorrect please let me know. I find it odd that this has been around for 5 years without being reported? Is that correct? It concerns me that maybe I am missing context here.
Anyhow, I hope this helps. Accept or reject. I am just trying to help. :)