print status to console; handle prefix change

[segfault-bilibili]

I found that sometimes generate-db.js seems to unexpectedly skip some files which haven't yet finished downloading. It seems to be a silent error as well.

I then tried to fix this, although I still don't know why that could happen at all.

By the way, as you can see, I also did a refactor to separate fetchFile as a function.

[segfault-bilibili]

I'm sorry. I misunderstood the situation.

The real root cause was the fact that I changed TERMUX_APP_PACKAGE in scripts/properties.sh so that the prefix check here will never get passed:

command-not-found/generate-db.js

Lines 41 to 45 in e187c10

	let linesContainingPathToBinaries = ungzipped
	.split("\n")
	.filter((line) => {
	return line.startsWith(binPrefix);
	});

.. and then forEach will never do anything because the array is empty:

command-not-found/generate-db.js

Lines 64 to 71 in e187c10

	Object.keys(binMap)
	.sort()
	.forEach((packageName) => {
	fs.appendFileSync(headerFile, `"${packageName}",\n`);
	binMap[packageName].sort().forEach((packageName) => {
	fs.appendFileSync(headerFile, `" ${packageName}",\n`);
	});
	});

[segfault-bilibili]

Currently my incorrect "fix" did nothing but creating empty files so that the compiler won't refuse to continue. However this obviously is not a proper fix at all.

[segfault-bilibili]

I've updated my patch. However I'm not sure whether it's correct or not.

[thunder-coding]

Kindly also rebase against master since huge parts of this script have been rewritten.

[thunder-coding]

Bad idea to use regex, if simple string comparision works well. Also hardcodes the prefix

[segfault-bilibili]

Also hardcodes prefix

Oh I think it's used to replace the hardcoded default prefix? Maybe something has changed as time goes by.

[thunder-coding]

Same suggestion, don't use regex

[thunder-coding]

Why are you moving from https to http2? http2 does not require encryption https://http2.github.io/faq/#does-http2-require-encryption which can be a problem

[segfault-bilibili]

Oh I didn't go deeper with that. I think the URL is still https so it is still encrypted. Did I get anything wrong?

[segfault-bilibili]

Honestly I'm considering to close this pr now.

The comments of this pr discussion thread now look confusing even to myself. It was composed quite some time ago. It was probably composed on a dirty tree instead of clean one as well.

The initial problem I wanted to fix turned out to be just a mistake introduced by myself. That's why I edited the initial comments on this discussion thread, putting strikethrough on the text.

However at that time I still thought that this pr maybe still make some sense, therefore I decided to leave it here.

[segfault-bilibili]

The hardcoded prefix issue seems to be rooted at very fundamental level of termux project as I l'm getting less and less unfamiliar with this project.

I now think it's reasonable to support dynamic prefix as this would fix multiuser support.

However this is probably not very easy to be done.

The only way I'm currently aware of, is a hackish way to use a default prefix with placeholding characters, so that it can be replaced with /user/12345 at installation time, thus, this text replacement is done without changing the length of string. termux/termux-app#2734

I wrote "handle prefix change" in the title, however it just replaces the prefix from one hardcoded string to another hardcoded string. It's still not a fix to this problem. It not even doing the hackish installation-time text replacement mentioned above. (however it still makes some sense in case that someone just needs to change the hardcoded prefix, instead of moving towards dynamic prefix)