Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: termux-file-editor now empty #2247

Closed
Eli-the-Bearded opened this issue Aug 26, 2021 · 5 comments
Closed

[Bug]: termux-file-editor now empty #2247

Eli-the-Bearded opened this issue Aug 26, 2021 · 5 comments

Comments

@Eli-the-Bearded
Copy link

Problem description

Android 11, $TERMUX_VERSION shows 0.117.

Until recently I could < share photos from F-Stop Gallery with Termux and run my ~/bin/termux-file-editor to process the images. Something has changed, and I'm not sure if it is F-Stop doing things wrong, or Termux not handling F-Stop's new way of doing things.

According to the (shown in-app and impossible to link to) changelog for F-Stop 5.3.27:

  • When sharing file, F-Stop will also send Title. Useful for sharing to Whatsapp, for example

I see no other sharing changes in any 5.x version.

What happens now with Termux is the save file toast no longer shows a default filename and if I provide one manually, I get a zero length file. I have verified with another program that the old behavior, get a default filename and get a file saved in $HOME/downloads still works, so it is not 100% broken.

I've contacted F-Stop support, too, but I have not heard a response from them.

Steps to reproduce the behavior.

Use F-Stop 5.3.27 (or probably newer) to share a file with Termux.

The changelog explicitly says 5.3.27 introduced new changes to F-Stop sharing.

What is the expected behavior?

Shared files are received in Termux.

System information

  • Termux application version: 0.117 installed from F-Droid
  • Android OS version: 11 (2021-08-01 security update)
  • Device model: oneplusn10
@agnostic-apollo
Copy link
Member

Thanks for the report. Should be fixed in next release.

The intent being passed was following. Filename is working too, but is being found through ContentResolver DISPLAY_NAME and android.intent.extra.TITLE extra is not being passed.

Intent { act=android.intent.action.SEND typ=image/jpeg flg=0x800003 cmp=com.termux/.filepicker.TermuxFileReceiverActivity clip={image/jpeg T:} (has extras) }
    Bundle[
    android.intent.extra.TEXT: ``
    android.intent.extra.STREAM: `content://media/external/images/media/xxxxxxx`
    ]

@Eli-the-Bearded
Copy link
Author

Very fast! Any idea when a 0.118 release will happen? Or should I bite the bullet and switch to the Github builds?

@agnostic-apollo
Copy link
Member

Some work is currently on going, so release will take a few days at least. Then roughly ~5-7 days will be taken by F-Droid itself for publishing. If you want faster updates, then Github builds would be ideal.

@Eli-the-Bearded
Copy link
Author

For the record, seeing this fixed in the F-droid version as of this week.

@agnostic-apollo
Copy link
Member

Great! Thanks for reporting and feedback.

AdamMickiewich pushed a commit to VolyaTeam/dzida-app that referenced this issue Aug 8, 2022
…ntent extras

- If the `EXTRA_TEXT` value of the intent passed was empty instead of `null`, it was incorrectly assumed that text was passed, even though a valid `EXTRA_STREAM` may have been passed. Now `EXTRA_STREAM` will be checked first.
- Added empty extra and empty/`null` filename checks before trying to create a file with an empty filename and failing.
- Enable logging of intent passed at verbose log level.
- Changed to a better error dialog.

Closes termux#2247
shrihankp pushed a commit to reisxd/termux-app that referenced this issue Oct 20, 2022
…ntent extras

- If the `EXTRA_TEXT` value of the intent passed was empty instead of `null`, it was incorrectly assumed that text was passed, even though a valid `EXTRA_STREAM` may have been passed. Now `EXTRA_STREAM` will be checked first.
- Added empty extra and empty/`null` filename checks before trying to create a file with an empty filename and failing.
- Enable logging of intent passed at verbose log level.
- Changed to a better error dialog.

Closes termux#2247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants