Unified UI colors across the app. #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Oct 7, 2019
There was a problem hiding this comment.
You made drawer entirely black and your change is permanent which isn't good. There are people who don't like "completely black" interface (e.g. like me) or ones who use light console themes.
App behaviour is configured through properties (https://wiki.termux.com/wiki/Terminal_Settings) handled in https://github.com/termux/termux-app/blob/master/app/src/main/java/com/termux/app/TermuxPreferences.java#L147. So it is possible to make UI black by introducing propertly like use-black-ui and setting it to true in config.
Current variant is not acceptable for merging.
|
Thanks for response @xeffyr I've made some changes, please check if it's up to your standard now. |
ghost
approved these changes
Oct 13, 2019
|
@rozPierog Nice work! |
ghost
mentioned this pull request
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made sidebar black instead of white and made app use dark android theme for consistency in Alert Dialogs etc. No more being blinded by UI elements at night
fixes #789
fixes #781