Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra keys: handle actions UP & CANCEL separately #1358

Merged
merged 2 commits into from
Nov 24, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented Nov 23, 2019

Extra keys shouldn't perform any action if button click was cancelled.
Fixes: #905.

Additionally:

  • Disable manual handling of DnD for API 28 and higher (Google simplified it and seems there no way to detect total silence mode). Maybe for higher SDK versions we even do not need to handle it manually, but I don't have device to verify this.

Leonid Plyushch added 2 commits November 23, 2019 15:22
Do not disturb mode is now handled only for SDKs pre-28. Extra keys will
not vibrate only when total silence mode is used.
@fornwall fornwall merged commit 8784188 into master Nov 24, 2019
@ghost ghost deleted the extra-keys branch November 24, 2019 18:12
@fornwall
Copy link
Member

Released in version 0.83 or higher (Android 7+ devices will get version 0.84).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent accidental key press when swiping the extra keys view to the left to access the text input view
1 participant