-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(main/termux-tools): new motd design #11222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please rewrite commit messages to match the formats used in git history, or the format specified in chore(CONTRIBUTING.md): enforce commit guidelines #10748.
- Please update
TERMUX_PKG_VERSION
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the commits.
After |
Done! |
Oh wait, i'm gonna fix this unbound variable error, it should successfully build now |
The icon you are adding on the left will break when text wrap engages when terminal width is less than characters per line. |
And |
Also the |
Okay, now i've replaced the unicode characters with white colored spaces, and shortened the lines for supporting the default zoom on termux and replaced $TERMUX_VERSION with $TERMUX_APP__VERSION_NAME |
|
So that means, all lines with "echo -e" wouldn't be executed, and colored spaces, bold and underline wouldn't work |
There will no |
@TomJo2000 Provided a way to execute environment variables and colors in motd using ESC characters. |
Change of plans, i'll add a dynamic motd |
Thought I'd drop in here for a quick comment. The last thing I'd want is to break something with this. |
Now it's ready for building |
So.. should i replace wiki with IRC? |
The community link already has And instead of wiki, use |
Done |
PR's TERMUX_PKG_VERSION Version is already being used by another approved PR now |
Version needs to be bumped, so please set it to 1.21 and force push to the branch |
Okay, but the PR will show some non related commits |
Please rebase and resolve conflicts to get rid of them |
They won't disappear, and the commit related to conflict fix won't appear in git rebase, even after git pull |
Please help, the PR is broken now |
Added a new termux motd dynamic design. Closes #11222 Co-authored-by: TomJo2000 <tomjo00@web.de>
enhance(main/termux-tools): Added a new motd design
For aesthetic pruposes, changed the motd by adding a small termux icon, termux version display and a hint to fix repo issues related to termux-change repo.
And also, now login executes a dynamic motd.sh, which can expand environment variables and display text formatting.
Common motd support wasn't removed, since now the login just distinguishes between dynamic and common motd (prioritising the dynamic motd)
Preview:
Co-authored-by: TomJo2000