-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build-bootstraps: bump to 0.2.0 #9382
Conversation
CC @agnostic-apollo as well for review |
Seems fine otherwise from an overlook. This won't affect normal builds, so have you ensured that reversal with And ideally, version bump commit should be separate from code change commits themselves. |
Maybe add a comment in the bootstrap script or ffmpeg and deps' build.sh that they cannot be built without neon. Does the build of those packages just fail, or do they give an error when run on device? |
4e3fda6
to
fd02791
Compare
* add support for building additional packages first
* add support for building ARM packages without Neon
* fix extract_debs to only extract compatible packages for targeted architecture
fd02791
to
78fd028
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Dropping the proposed support for Arm no Neon. I am unhappy with the results so far. Trying to add back support for no Neon arm arch is far more convoluted than I thought. I cannot guarantee rebuilt C++ programs will work due to android/ndk#1672. Even if it's not C++, I cannot confidently say the packages work without any extra gotchas. The ROM I am running already have some sort of qemu to intercept SIGILLs and it doesn't always work. Python doesn't work without the qemu (have to inject with LD_PRELOAD). Now GDB depends on Python is just icing on the cake on dozens and dozens of compatibility issues to troubleshoot that keep piling up as time goes on. Then there's the cleaning up. So far haven't found a good way to clean up after using sed. Too much assumptions. Probably will set up a repo if there's really people out there wanting to use some packages on <1GB RAM slow cores tablets in 2022 that can't even play 720p video properly. I will probably tidy up this PR and left with fixes in the coming days. Also a script to install bootstrap.zip, usable by |
Part of an initiative from #8927
Note that not all packages currently can be built without problems, notably ffmpeg and its deps. Have to delve deeper separately.