Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-bootstraps: bump to 0.2.0 #9382

Closed
wants to merge 4 commits into from

Conversation

truboxl
Copy link
Contributor

@truboxl truboxl commented Mar 12, 2022

Part of an initiative from #8927

  • add support building for ARM without Neon
  • add support building additional packages first

Note that not all packages currently can be built without problems, notably ffmpeg and its deps. Have to delve deeper separately.

@truboxl truboxl requested a review from Grimler91 as a code owner March 12, 2022 13:59
@truboxl
Copy link
Contributor Author

truboxl commented Mar 12, 2022

CC @agnostic-apollo as well for review

@agnostic-apollo
Copy link
Member

Seems fine otherwise from an overlook. This won't affect normal builds, so have you ensured that reversal with sed is working fine for you?

And ideally, version bump commit should be separate from code change commits themselves.

@Grimler91
Copy link
Member

Maybe add a comment in the bootstrap script or ffmpeg and deps' build.sh that they cannot be built without neon. Does the build of those packages just fail, or do they give an error when run on device?

@truboxl truboxl marked this pull request as draft March 13, 2022 00:45
@truboxl truboxl force-pushed the bootstrap-arm_vfpv3-d16 branch 3 times, most recently from 4e3fda6 to fd02791 Compare March 19, 2022 03:20
truboxl added 4 commits March 19, 2022 15:43
* add support for building additional packages first
* add support for building ARM packages without Neon
* fix extract_debs to only extract compatible packages for targeted
  architecture
@truboxl truboxl force-pushed the bootstrap-arm_vfpv3-d16 branch from fd02791 to 78fd028 Compare March 19, 2022 07:43
@MohammadTariq13

This comment was marked as off-topic.

@truboxl
Copy link
Contributor Author

truboxl commented Apr 12, 2022

Dropping the proposed support for Arm no Neon. I am unhappy with the results so far. Trying to add back support for no Neon arm arch is far more convoluted than I thought.

I cannot guarantee rebuilt C++ programs will work due to android/ndk#1672. Even if it's not C++, I cannot confidently say the packages work without any extra gotchas. The ROM I am running already have some sort of qemu to intercept SIGILLs and it doesn't always work. Python doesn't work without the qemu (have to inject with LD_PRELOAD). Now GDB depends on Python is just icing on the cake on dozens and dozens of compatibility issues to troubleshoot that keep piling up as time goes on.

Then there's the cleaning up. So far haven't found a good way to clean up after using sed. Too much assumptions.

Probably will set up a repo if there's really people out there wanting to use some packages on <1GB RAM slow cores tablets in 2022 that can't even play 720p video properly.

I will probably tidy up this PR and left with fixes in the coming days. Also a script to install bootstrap.zip, usable by /system/bin/sh. Rebuilding APK shouldn't be the only option of using bootstrap archives. Bonus for the ability to run 32bit environment on 64bit OS without having to use debug APKs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants