-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge in changes from @asnowfix fork #17
Conversation
Guest properties
Add gomock
multi-OS vbhostd
# Conflicts: # cmd/vbhostd/open_windows.go
Makefile helper
…-asnowfix # Conflicts: # .gitignore # .travis.yml # README.md # disk.go # machine.go
Hello @asnowfix, with this PR I am pulling in all the changes which reside in your fork of this repo. The merge commit however still has some problems. I'm not so much a Go developer so I need some input to get the unit test running. On our setup, we were already on Go 1.12, so I assume that the failure has to do with this. Could you have a look?
|
Only after I submitted the request for help, I noticed that the tests failed on my laptop but worked on TravisCI. The difference was the Go version. My laptop was running Go 1.13 and TravisCI 1.12. So I added Go 1.13 to the Travis setup to verify the failure I noticed on my laptop. So a search around the webs for In another issue, I found an example workaround: flipt-io/flipt@cd7fb49#diff-77b87a2786da4b38e7dd9d4fd463953c Commit 44041a6 contains a similar fix which now also makes the tests work on Go 1.13. |
@VoyTechnology do you have some time to review? Please let me know. If you don't have time, I will go forward as-is with merging this. |
Going forward with this. |
Merge in changes from the fork of @asnowfix. Let us first stabilize this branch via this PR.
TODO: