Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alliance amino signatures #131

Merged
merged 3 commits into from
May 16, 2023
Merged

fix: alliance amino signatures #131

merged 3 commits into from
May 16, 2023

Conversation

emidev98
Copy link
Contributor

This pull request implements the following changes from alliance module terra-money/alliance#173.

@emidev98 emidev98 added the bug Something isn't working label Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #131 (2efaa75) into main (01f8498) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   78.03%   78.03%           
=======================================
  Files           4        4           
  Lines         701      701           
=======================================
  Hits          547      547           
  Misses        140      140           
  Partials       14       14           

Copy link
Contributor

@gregnuj gregnuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to break consensus?

@emidev98
Copy link
Contributor Author

Yes, it will require a software upgrade but it still need to be reviewed

javiersuweijie
javiersuweijie previously approved these changes May 11, 2023
Copy link
Member

@javiersuweijie javiersuweijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we need to have a proper release plan for this since this is a consensus breaking change

@javiersuweijie
Copy link
Member

@gregnuj should this PR be merged into the release/2.3 branch instead?

go.mod Outdated
github.com/tendermint/tendermint v0.34.27
github.com/tendermint/tm-db v0.6.8-0.20221109095132-774cdfe7e6b0
github.com/terra-money/alliance v0.1.0-beta1
github.com/terra-money/alliance v0.1.1-rc.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update to use [v0.1.1](https://github.com/terra-money/alliance/releases/tag/v0.1.1)

@gregnuj gregnuj changed the base branch from main to release/v2.3 May 16, 2023 17:00
@gregnuj gregnuj dismissed javiersuweijie’s stale review May 16, 2023 17:00

The base branch was changed.

@gregnuj gregnuj changed the base branch from release/v2.3 to main May 16, 2023 17:01
@gregnuj
Copy link
Contributor

gregnuj commented May 16, 2023

merge to main.... will be release 2.4 since it breaks consensus

@gregnuj gregnuj merged commit 458ba8a into main May 16, 2023
@emidev98 emidev98 deleted the fix/alliance/amino branch May 23, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants