Fixing validation records when wildcard is present with alternative d…

[mmiranda]

…omains

Description

This PR address changes related to Issue #27.

Creates validation records for all SANs with wildcard

[mmiranda]

@antonbabenko any chance to get this merged?

[antonbabenko]

Thanks @mmiranda for this fix!

This PR has fixed issue #27.

v2.5.0 of this module has been just released.

[mignaulo]

Apologies for commenting on an already merged PR - Could someone explain why length(local.distinct_domain_names) + 1 (specifically the + 1) is required here? It always seems to wraparound the list and create the first element twice.

module.deploy-certificate.aws_route53_record.validation[2]: Creation complete after 36s [id=XXXXXXXX__4646f770db759d1fb15a85334855c.deploy.example.com._CNAME]
module.deploy-certificate.aws_route53_record.validation[1]: Creation complete after 37s [id=XXXXXXXX__5a3e97a89c32db71bf862e73e50a3.deploy.internal.example.com._CNAME]
module.deploy-certificate.aws_route53_record.validation[0]: Creation complete after 37s [id=XXXXXXXX__46456770db759d1fb15a85334855c.deploy.example.com._CNAME]

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.