Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change subnets default value to null #341

Merged

Conversation

andyli
Copy link
Contributor

@andyli andyli commented Jan 8, 2024

Description

Change default of subnets from [] to null.

Motivation and Context

Fix #340.

Breaking Changes

No. As far as I know, the previous default of subnets = [] is useless, because

  • the default will be overridden when subnets is provided by user, or
  • the default will be ignored when subnet_mapping is provided by user.

How Has This Been Tested?

  • I have executed pre-commit run -a on my pull request

@andyli andyli changed the title fix: subnets defaults to null to ease usage of subnet_mapping (#340) fix: subnets defaults to null to ease usage of subnet_mapping Jan 8, 2024
@andyli andyli changed the title fix: subnets defaults to null to ease usage of subnet_mapping fix: subnets defaults to null Jan 8, 2024
@andyli andyli changed the title fix: subnets defaults to null change subnets default to null Jan 8, 2024
@andyli andyli changed the title change subnets default to null fix: Change subnets default to null Jan 8, 2024
@bryantbiggs
Copy link
Member

I don't believe this is accurate - ref: hashicorp/terraform-provider-aws#17281 (comment)

@andyli
Copy link
Contributor Author

andyli commented Jan 9, 2024

As I've mentioned in #340, the issue happens since AWS provider v5.31.0.

The current version of terraform-aws-alb stated the AWS provider version constraint as >= 5.31:

required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 5.31"
}
}

The comment in #17281 was describing AWS provider v5.25.0. The "fix" of that landed in v5.31.0, which caused the issued I described in #340.

@bryantbiggs bryantbiggs changed the title fix: Change subnets default to null fix: Change subnets default value to null Jan 12, 2024
@bryantbiggs bryantbiggs merged commit a28fe0b into terraform-aws-modules:master Jan 12, 2024
9 of 13 checks passed
antonbabenko pushed a commit that referenced this pull request Jan 12, 2024
### [9.4.1](v9.4.0...v9.4.1) (2024-01-12)

### Bug Fixes

* Change `subnets` default value to `null` ([#341](#341)) ([a28fe0b](a28fe0b))
@antonbabenko
Copy link
Member

This PR is included in version 9.4.1 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants