fix: Do not create a deployment when a version is not provided #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlnrt
changed the title
mlnrt
changed the title
bryantbiggs
changed the title
bryantbiggs
approved these changes
Oct 30, 2023
antonbabenko
pushed a commit
that referenced
this pull request
Oct 30, 2023
### [1.1.4](v1.1.3...v1.1.4) (2023-10-30) ### Bug Fixes * Do not create a deployment when a version is not provided ([#7](#7)) ([46ab6cb](46ab6cb))
|
This PR is included in version 1.1.4 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the condition to create a aws_appconfig_deployment to check if a version is passed
Motivation and Context
If we want to create an AppConfig without a deployment and do not set var.deployment_configuration_version, the module returns an error because it tries to create a depyment version even if it is not set
Breaking Changes
This change does not break backwards compatibility with the current major version
How Has This Been Tested?
I updated the examples/ssm_parameter and tested it locally using the pre-commit but did not include the change to the example in this PR