feat: Introduce IPv6 CIDR specific allow ALBs variables #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 18, 2021 12:59
Attempt to fix an error: > Error: Error authorizing security group rule type ingress: InvalidParameterValue: CIDR block 2606:50c0::/32 is malformed
velimir
changed the title
velimir
changed the title
antonbabenko
approved these changes
Apr 25, 2022
|
Please fix the CI before we can merge it. |
added 3 commits
April 25, 2022 21:02
to avoid forcing the resource re-creation
`terraform-aws-modules/s3-bucket/aws` requires `aws = ">= 4.5"` since the change terraform-aws-modules/terraform-aws-s3-bucket#149
antonbabenko
pushed a commit
that referenced
this pull request
Apr 26, 2022
## [3.15.0](v3.14.0...v3.15.0) (2022-04-26) ### Features * Introduce IPv6 CIDR specific allow ALBs variables ([#275](#275)) ([bc5ad7c](bc5ad7c))
|
This PR is included in version 3.15.0 🎉 |
titanlien
pushed a commit
to Flaconi/terraform-aws-atlantis
that referenced
this pull request
Jun 8, 2022
titanlien
pushed a commit
to Flaconi/terraform-aws-atlantis
that referenced
this pull request
Jun 8, 2022
## [3.15.0](terraform-aws-modules/terraform-aws-atlantis@v3.14.0...v3.15.0) (2022-04-26) ### Features * Introduce IPv6 CIDR specific allow ALBs variables ([terraform-aws-modules#275](terraform-aws-modules#275)) ([bc5ad7c](terraform-aws-modules@bc5ad7c))
titanlien
pushed a commit
to Flaconi/terraform-aws-atlantis
that referenced
this pull request
Jun 8, 2022
titanlien
pushed a commit
to Flaconi/terraform-aws-atlantis
that referenced
this pull request
Jun 8, 2022
## [3.15.0](terraform-aws-modules/terraform-aws-atlantis@v3.14.0...v3.15.0) (2022-04-26) ### Features * Introduce IPv6 CIDR specific allow ALBs variables ([terraform-aws-modules#275](terraform-aws-modules#275)) ([bc5ad7c](terraform-aws-modules@bc5ad7c))
titanlien
pushed a commit
to Flaconi/terraform-aws-atlantis
that referenced
this pull request
Jun 9, 2022
titanlien
pushed a commit
to Flaconi/terraform-aws-atlantis
that referenced
this pull request
Jun 9, 2022
## [3.15.0](terraform-aws-modules/terraform-aws-atlantis@v3.14.0...v3.15.0) (2022-04-26) ### Features * Introduce IPv6 CIDR specific allow ALBs variables ([terraform-aws-modules#275](terraform-aws-modules#275)) ([bc5ad7c](terraform-aws-modules@bc5ad7c))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow users to provide IPV6 CIDR blocks for the AWS ALBs
Motivation and Context
Github started using IPv6 addresses.
If Atlantis is configured to allow GitHub IPs (via
alb_ingress_cidr_blocksusing "github" provider), terraform would fail with the following error:Addressed the stale comments on #217 (Fixed #217)
Breaking Changes
No breaking changes.
How Has This Been Tested?
Tested manually.