Added support for CPU credits

[antonbabenko]

Closes #31

[suizman]

Hi @antonbabenko it seams that this option breaks the compatibility with other instance types.

Error: Error applying plan:

1 error(s) occurred:

* module.ec2.aws_instance.this: 1 error(s) occurred:

* aws_instance.this: Error launching source instance: InstanceCreditSpecification.NotSupported: The m4.2xlarge instance type does not support T2 Unlimited.

Is there anyway to work around this without modifying the module?

[antonbabenko]

cpu_credits should be set only for T2 types of instances.

[suizman]

Of course but cpu_credit has a default value which is "standard".
This is my actual usage of the ec2 module

module "ec2" {
  source = "terraform-aws-modules/ec2-instance/aws"

  name                        = "qed-benchmark"
  ami                         = "${data.aws_ami.amazon_linux.id}"
  instance_type               = "${var.flavour}"
  subnet_id                   = "${element(data.aws_subnet_ids.all.ids, 0)}"
  vpc_security_group_ids      = ["${module.security_group.this_security_group_id}"]
  associate_public_ip_address = true
  key_name                    = "${aws_key_pair.qed-benchmark.key_name}" 

  root_block_device = [{
    volume_type = "gp2"
    volume_size = "${var.volume_size}"
    delete_on_termination = true
  }]
}

[antonbabenko]

Hmm, this is a nasty surprise :-/ I will release a fix soon.

[suizman]

Okis, thanks!
The current workaround I've found is to bring up some t2.$size instance and then choose another size and run terraform apply again. It's not a big deal..

[antonbabenko]

v1.9.0 has been released.

[suizman]

Perfect! I've just tested the changes and they work as expected. Thanks @antonbabenko

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.