Skip to content

Commit

Permalink
fix: Dynamic network configuration in service module for external dep…
Browse files Browse the repository at this point in the history
…loyments with awsvpc networkmode (#185)

fix: #184
  • Loading branch information
oliverlambson authored Apr 1, 2024
1 parent 7120f2b commit c817ed9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion modules/service/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ resource "aws_ecs_service" "this" {

dynamic "network_configuration" {
# Set by task set if deployment controller is external
for_each = var.network_mode == "awsvpc" ? [{ for k, v in local.network_configuration : k => v if !local.is_external_deployment }] : []
for_each = var.network_mode == "awsvpc" && !local.is_external_deployment ? [local.network_configuration] : []

content {
assign_public_ip = network_configuration.value.assign_public_ip
Expand Down

0 comments on commit c817ed9

Please sign in to comment.