-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thumbprint list should only include CA fingerprint #2732
Comments
This issue has been automatically marked as stale because it has been open 30 days |
if you'd like to open a PR, I'll merge it |
As per terraform-aws-modules#2732 and #32847, only the CA thumbprint should be included in the OIDC provider thumbprint list.
As per terraform-aws-modules#2732 and #32847, only the CA thumbprint should be included in the OIDC provider thumbprint list.
As per #2732 and #32847, only the CA thumbprint should be included in the OIDC provider thumbprint list.
### [19.17.1](v19.17.0...v19.17.1) (2023-10-06) ### Bug Fixes * Only include CA thumbprint in OIDC provider list ([#2769](#2769)) ([7e5de15](7e5de15)), closes [#2732](#2732) [#32847](https://github.com/terraform-aws-modules/terraform-aws-eks/issues/32847)
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Is your request related to a new offering from AWS?
No
Is your request related to a problem? Please describe.
#2307 updated the OIDC provider
thumbprint_list
to include all certificate fingerprints. This was valid at the time, since that's what the Terraform docs recommended. However, the docs have since been updated to recommend against this (hashicorp/terraform-provider-aws#32847).Here's what's in the latest docs:
Additionally, including all fingerprints can cause issues since AWS only allows a maximum of 5 to be specified (#2632). So if you want to provide extra fingerprints, there may not be room.
I also think that official AWS tooling (Console, eksctl) only populates the CA fingerprint. Here's eksctl, for example:
https://github.com/eksctl-io/eksctl/blob/fb50ae558a9f9c3259fc42bda7cc3957a1d824d5/pkg/iam/oidc/api.go#L113
Describe the solution you'd like.
Go back to the behavior before #2307 and only include the CA fingerprint in
thumbprint_list
.Describe alternatives you've considered.
Do nothing and live with the fact that this module behaves differently from what AWS and Terraform recommend.
Additional context
The text was updated successfully, but these errors were encountered: