feat: Add ability to support spot options for launch template

[davidweizheng]

PR o'clock

Description

Add ability to support spot options for launch template to address this issue: #1626

Checklist

• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[sergeyshevch]

Maybe someone can review and accept it? I also interested in such feature

[bryantbiggs]

@davidweizheng could you update an example so that it can be tested/validated and also for demonstrating its use to users - please 🙏🏽 and thank you!

[daroga0002]

code should be able to take a default provider values in cae of missing value for field. As a lot of them are optional we cannot require to put null from users.

Here you can take a look of some constructions which we using to make such optional inputs:

terraform-aws-eks/modules/node_groups/launch_template.tf

Lines 88 to 92 in 56e93d7

	metadata_options {
	http_endpoint = lookup(each.value, "metadata_http_endpoint", null)
	http_tokens = lookup(each.value, "metadata_http_tokens", null)
	http_put_response_hop_limit = lookup(each.value, "metadata_http_put_response_hop_limit", null)
	}

terraform-aws-eks/modules/fargate/main.tf

Lines 66 to 69 in 56e93d7

	timeouts {
	create = try(each.value["timeouts"].create, null)
	delete = try(each.value["timeouts"].delete, null)
	}

[davidweizheng]

Thanks @daroga0002 . This is very helpful. I'll definitely take a look.

[davidweizheng]

Fixed.

[davidweizheng]

@davidweizheng could you update an example so that it can be tested/validated and also for demonstrating its use to users - please 🙏🏽 and thank you!

I do have example in docs/spot-instances.md, but I'll try to add that as an actual example. Thanks.

[sergeyshevch]

Ping this one more time )

[davidweizheng]

Could someone review this?

[github-actions]

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

[antonbabenko]

This issue has been resolved in version 18.0.0 🎉

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.